FEDX-1707: Workiva Analysis Options v2 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
bender-wk
changed the title
| @@ -1,3 +1,4 @@ | |||
| include: package:workiva_analysis_options/v2.yaml | |||
| analyzer: | |||
| exclude: | |||
| - example/** | |||
There was a problem hiding this comment.
This is a limitation of the batch that was ran, but can we try removing the specified linter rules below this line?
Ideally we just lean on workiva_analysis_options provides
sourcegraph-wk
force-pushed
the
batch/fedx/workiva_analysis_options_v2
branch
from
8806afa to
6f87a87
Compare
robbecker-wf
approved these changes
Oct 17, 2024
|
QA+1 CI passes @Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEDX-1707
This PR bumps/adds workiva_analysis_options to v2. This is being done in an effort to adopt consistency in
analysis_options.yamlfiles across the codebase, and ensure all developers are using the most up to datefunctionality that the dart analyzer can provide.
Failing CI will be evaluated by someone from FEDX and resolved. We will reach out when the pr is ready for review.
If you have any questions, concerns, or opinions, please reach out to #support-frontend-dx.
Created by Sourcegraph batch change
Workiva/workiva_analysis_options_v2.